Use dedicated repos for @kadence packages #530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkout submodules Update tests.yml Update package-lock.json Testing with npm Testing with bun Update components Update components Update components Update package-lock.json Add workspace Delete bun.lockb Create bun.lockb Update tests.yml Update lock Optimization Update package lock npmrc Icon does not exist and is not referenced
oakesjosh
force-pushed
the
master
branch
2 times, most recently
from
128d4ba
to
cba8757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're increasingly running into instances where components between free and pro differ since they are separate codebases. This duplicates the setup used in blocks pro where packages are added as submodules at
/src/packages/from their repos (kadence-icons, kadence-helpers, kadence-components)Merging into nav so we have adequate testing and this can be part of a point release. The main risk with this is if there's changes that exist in the kadence-blocks repo for a component, that hadn't been updated in the kadence-components repo. I've done an initial check for this, but will do a second pass.
Other changes
.npmrcfile so we don't have to manually set--legacy-peer-depson npm installsStyleOnlyEntryPluginEventually, it'd be nice to include these as packages instead of submodules. This will add some overhead to local development and updating components though.